fix: preview app folder loading #11960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
force-pushed
the
fix/preview-app-folder-loading-2
branch
2 times, most recently
from
41c3591 to
7b00a72
Compare
Moves the folder loaders from the files app to `web-pkg` so they can be used from other packages.
JammingBen
force-pushed
the
fix/preview-app-folder-loading-2
branch
3 times, most recently
from
ca29fc6 to
6419ed5
Compare
Moves the method to build the search term to the `useSearch` composable so it can be used in other packages.
JammingBen
force-pushed
the
fix/preview-app-folder-loading-2
branch
from
6419ed5 to
ecbf5e0
Compare
dschmidt
reviewed
Nov 28, 2024
Fixes the image loading of the preview app in flat file lists (Shared with me page, search results etc.) so all images of the current file list are being loaded. Before, the preview app loaded the images of the folder the files are located in.
JammingBen
force-pushed
the
fix/preview-app-folder-loading-2
branch
from
ecbf5e0 to
d1a248c
Compare
|
dschmidt
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the image loading of the preview app in flat file lists (Shared with me page, search results etc.) so all images of the current file list are being loaded. Before, the preview app loaded the images of the folder the files are located in.
Some groundwork was needed to achieve that:
First I moved the folder loaders from the files app to
web-pkgbecause they need to be used to load the files in flat file lists. Then I moved the method for building the search term to theuseSearchcomposable so it also can be used globally.This PR is best reviewed by commits!
Known issues:
fixes #8932